[evolution-patches] Re: [Evolution] Patch to handle "file://" uri in Mail-component.

[Not Zed <notzed ximian com>]

Umm, you've gone and cut and pasted a huge chuck of mail code into
mail-component.  Don't.  Mail ALWAYS uses camel-url, don't use e-url.
Umm, you copy the message to the mailbox, and then run the action?  WTF?
There's no guarantee appended_uid will ever be set to anything useful
either.

The style formatting is all over the shop.

You've gone and added a huge chunk of new functionality into something
which is already well frozen, too.  You're completely changing the
semantics of evolution's filename handling.  Not to mention you've
COMPLETELY hardcoded it.  This alone isn't acceptable.

You're abusing the file url scheme anyway.


Umm, what on earth is this?  Whats the use of setting up a list with one
item so you can walk it afterwards?  Just bad cut and paste?

+               
+               file_names_list = g_slist_append(file_names_list,
euri->path);
+               
+               composer = e_msg_composer_new ();
+               while (file_names_list) {
+                       part =
e_msg_composer_add_inline_image_from_file(composer,
+
file_names_list->data);
+                       if (part)
+                               e_msg_composer_attach(composer, part);
+                       camel_object_unref(part);
+                       file_names_list = g_slist_next
(file_names_list);
+               }


Since this is presumably high priority since the god-master demanded
action, do whatever you want externally but internally its going to have
to operate on a proper uri, not a file one.  You shouldn't have to add
anything much at all in the mail-component code (if anything).

You definitely cannot hardcode anything in the shell code.  And you're
really pushing the bounds of 'feature freeze' with all of that too.


On Tue, 2005-07-26 at 18:42 -0600, Veerapuram Varadhan wrote: