Re: [evolution-patches] Exchange fix for #311323



Some small issues are there. Otherwise looks fine.

- We should use C style declaration means all the variable declarations
should be on top.

+               folder_name = g_strdup ("name");
+       account = exchange_operations_get_exchange_account ();
+       GtkListStore *model;
+       model = exchange_account_folder_size_get_model (account);
+       if (model)

- Same in 'e_exchange_calendar_pcalendar' function.
- Same in 'e_exchange_contacts_pcontacts' function.
- Bug number is missing in ChangeLog file.

Thanks,
Shakti


On Sat, 2005-07-23 at 16:52 +0530, Sarfraaz Ahmed wrote:
> Hi,
> 
> This patch fixes #311323. The ChangeLog explains the changes.
> 
> Thanks
> -- Sarfraaz
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]