Re: [evolution-patches] Patch to make Name Selector dialog intuitive (libedataserverui)

[Srinivasa Ragavan <sragavan novell com>]

Vivek,

SelData is not freed. It needs to be freed. Also you dont need 
these two decl.

+remove_button_clicked (GtkButton *button, SelData *data)
+{
+       GtkTreeView *view;
+       ENameSelectorDialog *name_selector_dialog;

Except this code looks fine for me. Even gui you showed me was pretty
neat. Im ok to commit after you fix this.

-Srini
On Mon, 2005-07-25 at 11:18 +0530, Vivek Jain wrote:
> hi,
> 
> Thanks for the comments. I have added the code in the patch to have
> icons for add and remove. Attached is the revised patch. Please let me
> know if it looks ok now, so that I can commit before UI freeze today.
> 
> Thanks,
> Vivek Jain
> 
> 
> On Fri, 2005-07-22 at 16:46 +0530, Srinivasa Ragavan wrote:
> > Vivek,
> > 
> > Yes it makes more intuitive. Buttons are to be associated with actions
> > not with data. You 'save' 'open' which are actions. But 'To', 'CC' etc
> > cant be actions. Also removing is not very clear. double click/delkey.
> > Most users wont require to come to the dialog to add it. But for users
> > who cant add in normal way, would find it difficult adding/removing
> > here.
> > 
> > Few comments in the dialog
> > 
> > * use gtk_label_set_use_underline to make the accelerator work properly.
> > * Use stock for  -> and <-. I showed you my earlier patch. It looks
> > ugly.
> > 
> > I havent seen the code DEEPLY. Some one should be able to comment on it.
> > 
> > Apart from that, it looks neat.
> > -Srini
> > 
> > On Fri, 2005-07-22 at 12:22 +0530, Vivek Jain wrote:
> > > hi,
> > > 
> > > This patch "tries" to make Name Selector dialog more intuitive. It
> > > provides the option for removing a selected entry as well. Though I
> > > myself have a feeling its little bit too ugly to have six buttons there
> > > (when invoked from composer) but guess some users would prefer it that
> > > way. Please gimme some ideas if you agree with me there.
> > > And of course in code, if something is not taken care of. 
> > > 
> > > Thanks,
> > > Vivek Jain
> > > _______________________________________________
> > > evolution-patches mailing list
> > > evolution-patches lists ximian com
> > > http://lists.ximian.com/mailman/listinfo/evolution-patches
> >