Re: [evolution-patches] UI_HACKFEST: Send & Receive Dialog

[Jeffrey Stedfast <fejj novell com>]

should probably also make sure the host is non-empty

Jeff

On Thu, 2005-07-21 at 20:02 +0530, Srinivasa Ragavan wrote:
> On Thu, 2005-07-21 at 17:51 +0530, Devashish Sharma wrote:
> > Hi,
> > 
> > Attached patch fixes #221270.
> > It enables Send & Receive mail dialog to show account name also.
> > So know it shows server name + Account Name + Type.
> > 
> > Thanks
> > 
> > Devashish Sharma
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > 
> > plain text
> > document
> > attachment
> > (patch.221270)
> > 
> > ? .mail-send-recv.c.swp
> > ? Evolution-Mail-common.c
> > ? Evolution-Mail-skels.c
> > ? Evolution-Mail-stubs.c
> > ? Evolution-Mail.h
> > ? evolution-mail-2.4.schemas
> > ? mail.error
> > ? default/zh_CN/Makefile
> > ? default/zh_CN/Makefile.in
> > Index: ChangeLog
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
> > retrieving revision 1.3654
> > diff -u -p -r1.3654 ChangeLog
> > --- ChangeLog   12 Jul 2005 04:04:12 -0000      1.3654
> > +++ ChangeLog   21 Jul 2005 12:17:23 -0000
> > @@ -1,3 +1,8 @@
> > +2005-07-21  Devashish Sharma <sdevashish novell com>
> > +       * mail-send-recv.c : Send & Receive mail dialog shows account
> > name also
> > +       So know it shows server name + Account Name + Type
> > +       fixes #221270
> > +       
> >  2005-07-10  Shreyas Srinivasan <sshreyas novell com>
> >  
> >         * mail-config.[ch]: Add new functions to remove proxy accounts
> > and
> > Index: mail-send-recv.c
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/mail/mail-send-recv.c,v
> > retrieving revision 1.98
> > diff -u -p -r1.98 mail-send-recv.c
> > --- mail-send-recv.c    23 Jun 2005 09:11:06 -0000      1.98
> > +++ mail-send-recv.c    21 Jul 2005 12:17:23 -0000
> > @@ -262,11 +262,12 @@ format_url(const char *internal_url)
> >  
> >         url = camel_url_new(internal_url, NULL);
> >         if (url->host)
> > -               pretty_url = g_strdup_printf(_("Server: %s, Type: %
> > s"), url->host, url->protocol);
> > +               pretty_url = g_strdup_printf(_("Server: %s, Account: %
> > s, Type: %s"), url->host, url->user, url->protocol);
> >         else if (url->path)
> I think you should check for account != NULL. The attached screenshot
> shows that. Also strip off the unnecessary portions in ur diff.
> > -               pretty_url = g_strdup_printf(_("Path: %s, Type: %s"),
> > url->path, url->protocol);
> > +               pretty_url = g_strdup_printf(_("Path: %s, Account: %s,
> > Type: %s"), url->path, url->user, url->protocol);
> >         else 
> > -               pretty_url = g_strdup_printf(_("Type: %s"),
> > url->protocol);
> > +               pretty_url = g_strdup_printf(_("Type: %s, Account: %
> > s"), url->protocol, url->user);
> > +       
> >  
> >         camel_url_free(url); 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com  - www.novell.com