Re: [evolution-patches] Exchange: Fix for bug 310433

[Sarfraaz Ahmed <asarfraaz novell com>]

Looks good. Few minor styling issues. Fix them and commit.


> +gboolean calendar_src_exists=FALSE;
> +gchar *calendar_old_source_uri=NULL;
> 
> Add spaces around the "="
> 
> +               tmpdelimit[0]='\0';
> 
> Similar
> 
> +               result = exchange_account_xfer_folder (account,
> oldpath, path, TRUE);
> 
> Handle the error result. Also make sure you are taking care of all the
> result error messages here. Will have to announce any new strings we
> need here.
> 
> 
>  
> -gchar *contacts_uri=NULL;
> +gboolean contacts_src_exists=FALSE;
> +gchar *contacts_old_src_uri=NULL;
> 
> Similar ...
> 
> 
> +               tmpdelimit[0]='\0';
> 
> Similar ....
> 
> +               result = exchange_account_create_folder (account,
> path, "contacts");
> 
> Handle errors ...
> 
> +       }
> +       else if (strcmp (e_source_peek_relative_uri (source),
> contacts_old_src_uri)) {
> +               /* Rename the folder */
> +               oldpath = g_strdup_printf ("/%s", contacts_old_src_uri
> +prefix_len);
> +               result = exchange_account_xfer_folder (account,
> oldpath, path, TRUE);
> 
> 
> Handle errors ...
> 
> +               exchange_operations_update_child_esources (source,
> contacts_old_src_uri, ruri);
> +       }
>  
> +void exchange_operations_update_child_esources (ESource *source,
> const gchar *old_path, const gchar *new_path);
> 
> You could split this into multiple lines
> 


-- Sarfraaz