Re: [evolution-patches] UI_HACKFEST: Save Draft Shortcut and Button

[Srinivasa Ragavan <sragavan novell com>]

My comments are below.

On Thu, 2005-07-21 at 16:01 +0530, Devashish Sharma wrote:
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/ui/ChangeLog,v
> retrieving revision 1.414
> diff -u -p -r1.414 ChangeLog
> --- ChangeLog   7 Jun 2005 06:02:01 -0000       1.414
> +++ ChangeLog   21 Jul 2005 10:13:37 -0000
> @@ -1,3 +1,8 @@
> +2005-07-21 Devashish Sharma <sdevashish novell com>
> +       * evolution-message-composer.xml: Added Shortcut for Save
> Draft
> +          -(Shift+Ctrl+D) and a toolbar button for the same.
> +           Fixes #219242
This should go into the change log of ui/Changelog. And you changelog
for e-msg-composer.c is missing.
> +           
>  2005-06-03  ANdre Klapper <a9016009 gmx de>
>         * evolution-mail-message.xml: Removing duplicate mnemonic,
>         this fixes bug 306153
> Index: evolution-message-composer.xml
> ===================================================================
> RCS file: /cvs/gnome/evolution/ui/evolution-message-composer.xml,v
> retrieving revision 1.47
> diff -u -p -r1.47 evolution-message-composer.xml
> --- evolution-message-composer.xml      16 May 2005 11:39:08
> -0000      1.47
> +++ evolution-message-composer.xml      21 Jul 2005 10:13:38 -0000
> @@ -7,7 +7,11 @@
>                 <cmd name="FileSave" _label="Save"
>                 _tip="Save the current file" pixtype="stock"
> pixname="gtk-save"
>                 accel="*Ctrl*s"/>
> -               
> +
Get rid of these unnecessary white spaces
> +               <cmd name="FileSaveDraft" _label="SaveDraft"
> +               _tip="Save as draft" 
> +               pixtype="pixbuf" accel="*Shift**Ctrl*d"/>
> +
>                 <cmd name="FileSaveAs" _label="Save As"
>                 _tip="Save the current file with a different name"
>                 pixtype="stock" pixname="gtk-save-as"/>
> @@ -147,6 +151,7 @@
>         
>         <dockitem name="Toolbar" behavior="exclusive" look="system">
>                 <toolitem name="FileSend" verb="" pixtype="pixbuf"
> priority="1"/>
> +               <toolitem name="FileSaveDraft" verb=""
> pixtype="pixbuf" priority="1"/>
Hmm nice place. I guess this fixes another ui bug, where the user wanted
the send/attach button apart, since he misses attach and sends mail
without attachments.
>                 <toolitem name="FileAttach" verb="" pixtype="pixbuf"
> priority="1"/>     
>  
>                 <separator f="" name="emailcomposer"/>
> ? mail-composer.error
> Index: e-msg-composer.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/composer/e-msg-composer.c,v
> retrieving revision 1.513
> diff -u -p -r1.513 e-msg-composer.c
> --- e-msg-composer.c    11 Jul 2005 11:26:31 -0000      1.513
> +++ e-msg-composer.c    21 Jul 2005 10:14:03 -0000
> @@ -1968,6 +1968,7 @@ static BonoboUIVerb verbs [] = {
>  static EPixmap pixcache [] = {
>         E_PIXMAP ("/Toolbar/FileAttach", "stock_attach",
> E_ICON_SIZE_LARGE_TOOLBAR),
>         E_PIXMAP ("/Toolbar/FileSend", "stock_mail-send",
> E_ICON_SIZE_LARGE_TOOLBAR),
> +       E_PIXMAP ("/Toolbar/FileSaveDraft", "stock_save",
> E_ICON_SIZE_LARGE_TOOLBAR) ,
>         
>  /*     E_PIXMAP ("/menu/Insert/FileAttach", "stock_attach",
> E_ICON_SIZE_LARGE_TOOLBAR), */
>         E_PIXMAP ("/commands/FileSend", "stock_mail-send",
> E_ICON_SIZE_MENU),
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
>