Re: [evolution-patches] Exchange patch for tasks

[shakti <shprasad novell com>]

Patch looks good and also working fine.

Thanks,
Shakti

Sarfraaz Ahmed wrote:

> Hi,
>
> A trivial fix for a crash. Fixes #310439
>
> Please review.
>
> -- Sarfraaz
>  
>
> ------------------------------------------------------------------------
>
> Index: ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution-exchange/ChangeLog,v
> retrieving revision 1.354
> diff -u -p -u -p -r1.354 ChangeLog
> --- ChangeLog	13 Jul 2005 11:08:45 -0000	1.354
> +++ ChangeLog	15 Jul 2005 12:22:12 -0000
> @@ -1,3 +1,8 @@
> +2005-07-15  Sarfraaz Ahmed <asarfraaz novell com>
> +
> +	* calendar/e-cal-backend-exchange-tasks.c (remove_task) : Access href
> +	of the cached object only if it exists. Fixes #310439
> +
> 2005-07-13  Sarfraaz Ahmed <asarfraaz novell com>
>
> 	* storage/exchange-account.h : No longer is needed here. Moved to e-d-s
> Index: calendar/e-cal-backend-exchange-tasks.c
> ===================================================================
> RCS file: /cvs/gnome/evolution-exchange/calendar/e-cal-backend-exchange-tasks.c,v
> retrieving revision 1.17
> diff -u -p -u -p -r1.17 e-cal-backend-exchange-tasks.c
> --- calendar/e-cal-backend-exchange-tasks.c	14 Jun 2005 13:12:43 -0000	1.17
> +++ calendar/e-cal-backend-exchange-tasks.c	15 Jul 2005 12:22:12 -0000
> @@ -1292,7 +1292,7 @@ remove_task_object (ECalBackendSync *bac
> 	}
>
> 	ecalbexcomp = get_exchange_comp (ecalbex, uid);
> -	if (!ecalbexcomp && !ecalbexcomp->href)
> +	if (!ecalbexcomp || !ecalbexcomp->href)
> 		return GNOME_Evolution_Calendar_ObjectNotFound;		
>
>         comp = e_cal_component_new ();
>  
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
>