Re: [evolution-patches] Patch for bug#310479 (Exchange-component)

[Sarfraaz Ahmed <asarfraaz novell com>]

Hi,

Some comments below.
> +++ exchange-folder-permission.c        15 Jul 2005 15:06:05 -0000
> @@ -30,20 +30,25 @@
> 
>  
> +void
> +org_gnome_exchange_calendar_permissions (EPlugin *ep,
> ECalPopupTargetSource *target)
> +{
> +
> +       if (! g_strrstr (uri, "exchange://") && !folder)        {
> +               return ;
> +       }
> 
> Move this check for uri in the beginning.
> 
> +
> +       selected_exchange_folder_uri = uri;
> +
> +       /* for translation*/
> +       if (first) {
> +               popup_items[0].label =  _(popup_items[0].label);
> +
> +       }
> 
> This check doesnt look very logical. Guess, you wanted to have this
> execute only once. You would have to initialise first to 0 and then
> have it incremented inside the if clause.
> 
> 
> +       if (! g_strrstr (uri, "exchange://") && !folder)        {
> +               return ;
> 
> Similar
> 
> +       }
> +
> +       selected_exchange_folder_uri = uri;
> +
> +       /* for translation*/
> +       if (first) {
> +               popup_items[0].label =  _(popup_items[0].label);
> +
> +       }
> 
> Similar
> 
> +
> +      
> 
> +++ exchange-permissions-dialog.c       15 Jul 2005 15:06:05 -0000
> @@ -560,8 +560,7 @@ display_role (ExchangePermissionsDialog 
>                             -1);
>  
>         if (role == E2K_PERMISSIONS_ROLE_CUSTOM) {
> -               gtk_widget_show (dialog->priv->separator);
> -               gtk_widget_show (dialog->priv->custom);
> +               /* FIXME: To show Custom */
>                 role = E2K_PERMISSIONS_ROLE_NUM_ROLES + 1;
> 
> What is this for ?
> 
>         }
> 

Thanks
-- Sarfraaz