Re: [evolution-patches] patch for e-passwords

[Not Zed <notzed ximian com>]

Ok, sounds fair, thanks for the explanation.  Please commit.


On Mon, 2005-07-18 at 10:41 +0800, Harry Lu wrote:
> Hi, Michael,
>     Evolution-jescs is the connector for Sun Calendar server. In it,
> we call e_passwords_ask_password to popup the password dialog. While
> the dialog is poping there, if user close Evolution, evolution-jescs
> want to quit and close the dialog automatically. So we called
> e_passwords_cancel. But we found though the dialog disappeard,
> evolution-jescs is hang there. The trace is :
> 
> #0  0xffffe410 in ?? ()
> #1  0xbfffe3f8 in ?? ()
> #2  0x000001f4 in ?? ()
> #3  0x00000007 in ?? ()
> #4  0x416fe804 in poll () from /lib/tls/libc.so.6
> #5  0x414d3463 in g_main_context_iterate (context=0x80b27e8, block=1, 
>     dispatch=1, self=0x8083080) at gmain.c:2875
> #6  0x414d36c5 in g_main_context_iteration (context=0x80b27e8,
> may_block=1)
>     at gmain.c:2632
> #7  0x403c9c0c in ep_msg_send (msg=0x810a640) at e-passwords.c:179
> #8  0x403caf8c in e_passwords_ask_password (title=0x807d308 "Enter
> password", 
>     component_name=0x807d2e2 "Evolution-jescs", 
>     key=0x8310ae8 "wcap://jack relay prc sun com:8080", 
>     prompt=0x8310c80 "Enter password for jack relay prc sun com",
> type=258, 
>     remember=0xbfffe514, parent=0x0) at e-passwords.c:739
> #9  0x0806ce95 in sunone_account_get_password (account=0x80e1fc8, 
>     is_interactive=1) at sunone-account.c:323
> 
>     So we need to response to the dialog (the pass_response will
> destory the dialog and reply the message) instead of destory the
> dialog directly.
>        Harry
> 
> 
> Wang Xin wrote: 
> > Hi,
> > Not yet, we found the problem when we develop evolution-jescs.
> > 
> > Regards,
> > 
> > Jedy
> > 
> > On Fri, 2005-07-15 at 18:14 +0800, Not Zed wrote:
> >   
> > > is there a particular bug or backtrace which demonstrates the problem
> > > this is fixing?
> > > 
> > > On Fri, 2005-07-15 at 18:18 +0800, Jedy Wang wrote:
> > >     
> > > > Sorry,
> > > > Forgot the patch.
> > > > 
> > > > Regards,
> > > > 
> > > > Jedy
> > > > 
> > > > On Fri, 2005-07-15 at 18:13 +0800, Jedy Wang wrote:
> > > >       
> > > > > Hi,
> > > > > 
> > > > > To kill a e-passwords dialog, we shall send a cancel reply, but not just
> > > > > simply destroy the widget. Because the dialog may be waiting for reply
> > > > > so probably hung the calling thread of e_passwords_ask_password.
> > > > > 
> > > > > Regards,
> > > > > 
> > > > > Jedy
> > > > > 
> > > > > 
> > > > > _______________________________________________
> > > > > evolution-patches mailing list
> > > > > evolution-patches lists ximian com
> > > > > http://lists.ximian.com/mailman/listinfo/evolution-patches
> > > > >         
> > > > _______________________________________________
> > > > evolution-patches mailing list
> > > > evolution-patches lists ximian com
> > > > http://lists.ximian.com/mailman/listinfo/evolution-patches
> > > >       
> > > _______________________________________________
> > > evolution-patches mailing list
> > > evolution-patches lists ximian com
> > > http://lists.ximian.com/mailman/listinfo/evolution-patches
> > >     
> > 
> > _______________________________________________
> > evolution-patches mailing list
> > evolution-patches lists ximian com
> > http://lists.ximian.com/mailman/listinfo/evolution-patches
> > 
> >