Re: [evolution-patches] Patch submission

[Jeffrey Stedfast <fejj novell com>]

please include a changelog in each patch

On Sat, 2005-07-16 at 02:36 -0700, riyaz ahmed wrote:
> 
> 
> On 7/13/05, Jeffrey Stedfast <fejj novell com> wrote:
>         it would be nice if you made a single diff and added the
>         changelog
>         entries to the proper changelog file.
>         
>         If you used emacs, it would auto-magically find the proper
>         ChangeLog
>         file for you and properly add the filename to the ChangeLog 
>         
>         eg, the ChangeLog entry should look more like this:
>         
>         2005-07-13  H.A.Riyaz Ahmed  <sunez riyaz gmail com>
>         
>                 Fixes bug #246244 and bug #246247
>         
>                 * src/menubar.c (function_modified): changed the value
>         of the argument
>         
>                 * src/propeties.c (function_modified): added the
>         condition statement
>         
>                 * src/body.c (function_modified): changed the argument
>         as required 
>         
>                 * src/utils.c (function_modified): changed the display
>         as mentioned
>         
>         
>         (Note: I'm assuming the files are in gtkhtml/src/ but that
>         might not be
>         the case)
>         
>         that said... you should also be a tad more descriptive in the
>         changelog. 
>         For example, body.c's change says "changed the argument as
>         required".
>         That doesn't at all describe what you changed. Instead, a
>         better
>         description might be:
>         
>         "changed the capitalisation of some words to conform to the
>         HIG" 
>         
>         your changes to properties.c does not follow the coding style.
>         Please
>         read the README.HACKING file and keep your coding style
>         consistant with
>         the surrounding code.
>         
>         also... why are there multiple patches to the same files?
>         which diff is 
>         the one we should be reviewing?
>         
>         
>         I suggest you make the following changes above (using `cvs
>         diff -up`
>         would be extremely useful as well) and then resend the single
>         resulting
>         patch.
> 
>    Hi ....
> I have remodified the patch as you have mentioned 
> ithink that this will be fine
>  Truly
>  H.A.Riyaz Ahmed
> 
> 
> 
> 
>         Jeff
>         
>         On Wed, 2005-07-13 at 17:49 +0530, riyaz ahmed wrote:
>         > hi,
>         >
>         >    i have attached the patches for  the bugs 246244( three
>         files ) ,
>         > 246247( three files ) and a
>         > changelog file
>         > these fixes the label and HIG-layout suggestions ,
>         >
>         >
>         > Truly 
>         > H.A.Riyaz Ahmed
>         > _______________________________________________
>         > evolution-patches mailing list
>         > evolution-patches lists ximian com
>         > http://lists.ximian.com/mailman/listinfo/evolution-patches
>         --
>         Jeffrey Stedfast
>         Evolution Hacker - Novell, Inc.
>         fejj ximian com  - www.novell.com
>         
>