Re: [evolution-patches] Patch to allow a contact to be opened in the editor from command-line.

[Veerapuram Varadhan <vvaradhan novell com>]

On Mon, 2005-07-11 at 18:23 +0530, Sushma Rai wrote:
> Apart from these... a few comments..
> 
> about the coding style in addressbook_view_edit_contact(),
> It's good if you return on failure and proceed otherwise..
> 
> for example
> book = e_book_new ();
> if  (!book) {
>     // log error and return
> }
> if  (!e_book_open()) {
>     // log error and return
> }
> etc..
> 
> You need not mark warning strings for translation.
> book and contact needs to be unrefed.
> Since you need both source uid and contact uid, it's better
> you return on either NULL source UID or contact UID.
> 
> Also there are some compiler warnings...
> addressbook_view_edit_contact() not declared in the header file,
> uid_view, uid are not used.
> 
I have fixed the style and other warnings from the code as mentioned
above and moved the _dispose_ call to proper place.

I am committing this for the feature-freeze now and will rework on the
url parsing, if needed, later.

Thanks,

V. Varadhan