Re: [evolution-patches] Patch to reduce the e_cal_is_read_only calls made by calendar clients.



On Fri, 2005-07-08 at 20:55 +0530, lviren wrote:

+               ecal->priv->cal_address = g_strdup (address);
                return;

The existing cal_address should be freed before assigning a new address.

+       if (*cal_address == NULL) {

The check should be made for priv->cal_address. Please correct the indentations.

*cal_address = priv->cal_address;

The value should be duped here. The caller would free the variable.

- Chenthill.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]