Re: Was [Re: [evolution-patches] itip-formatter plugin invocation URI fix.]

[Veerapuram Varadhan <vvaradhan novell com>]

On Fri, 2005-07-08 at 10:26 -0400, Jeffrey Stedfast wrote:
> > P.S:-
> > Having said/done all these.. i have a question...
> > 
> > should the url that we are currently using in itip-formatter plugin
> be 
> > "calendar:///?startdate=<date-time>&enddate=<date-time>"?
> > 
> > because "calendar://" is the protocol and "?" should follow a path,
> > isn't it?
> 
> I'm not sure, possibly.
> 
With the assumption that the invocation-url/uri should be
"calendar:///?startdate=<date-time>&enddate=<date-time>" instead of
"calendar://?startdate=<date-time>&enddate=<date-time>", I hereby attach
a patch to add the extra, required (IMO), "/" to the invocation-uri.

Let me know your comments.

Thanks,

V. Varadhan

Index: plugins/itip-formatter/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/plugins/itip-formatter/ChangeLog,v
retrieving revision 1.50
diff -u -p -r1.50 ChangeLog
--- plugins/itip-formatter/ChangeLog	27 Jun 2005 00:55:23 -0000	1.50
+++ plugins/itip-formatter/ChangeLog	8 Jul 2005 15:32:04 -0000
@@ -1,3 +1,8 @@
+2005-07-07  Veerapuram Varadhan:
+
+	* itip-formatter.c: (idle_open_cb): Pass the correct-URI to open
+	the respective day/time.
+	
 2005-06-27  Tor Lillqvist  <tml novell com>
 
 	* Makefile.am: Use NO_UNDEFINED. Link with more libraries.
Index: plugins/itip-formatter/itip-formatter.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/itip-formatter/itip-formatter.c,v
retrieving revision 1.43
diff -u -p -r1.43 itip-formatter.c
--- plugins/itip-formatter/itip-formatter.c	20 Jun 2005 17:27:52 -0000	1.43
+++ plugins/itip-formatter/itip-formatter.c	8 Jul 2005 15:32:17 -0000
@@ -1276,7 +1276,7 @@ idle_open_cb (gpointer data) 
 	FormatItipPObject *pitip = data;	
 	char *command;
 	
-	command = g_strdup_printf ("evolution-%s \"calendar://?startdate=%s&enddate=%s\"", BASE_VERSION, 
+	command = g_strdup_printf ("evolution-%s \"calendar:///?startdate=%s&enddate=%s\"", BASE_VERSION, 
 				   isodate_from_time_t (pitip->start_time), isodate_from_time_t (pitip->end_time));
 	if (!g_spawn_command_line_async (command, NULL)) {
 		g_warning ("Could not launch %s", command);