Re: [evolution-patches] Updated patch for Proxy

[chenthill <pchenthill novell com>]

On Fri, 2005-07-08 at 06:49 -0600, Pasupathilingam Sankarasivasubramanian wrote:
>      value = NULL;
>     +               subparam = soup_soap_parameter_get_first_child_by_name (param, "appointment");
>     +               if (subparam) {
>     +                       individualRights= soup_soap_parameter_get_first_child_by_name (subparam,"read");                                  

The proxy related parsing should be done in the e-gw-proxy.c file and the structures in that file can be named with E_GW_PROXY as the prefix.

+ EGwConnectionStatus e_gw_connection_remove_proxy (EGwConnection *cnc, proxyHandler *newProxy);
Just pass the item id here instead of passing the whole structure which is not needed at all.

user = e_source_get_property (priv->source, "parent_id_name");
+               if (user) {                     
+                  

The name "user" is not intuitive enough to specify it is a proxy account.


        user = e_source_get_property (priv->source, "parent_id_name");
+               if (user) {                     
+                       prompt = g_strdup_printf (_("Enter password for %s to enable proxy for user %s"), e_source_peek_name (priv->source), user);
+

The password should not be prompted for the proxy user again. The uri of the parent account should be passed as the key to get the password.

  added = TRUE;
+               soup_soap_message_start_element (msg, "mail", NULL, NULL);
+               e_gw_message_write_int_parameter (msg, "read", NULL, 1);
+       }
A small function used to write the elements in the soap message.

thanks, chenthill.