[evolution-patches] patch to fix #274329



hi,

Attached patch would fix problems causing

http://bugzilla.gnome.org/show_bug.cgi?id=274329

Though some of the fixes are already in, this patch fixes problem that
might cause similar crashes.

Thanks,
Vivek Jain
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/plugins/new-mail-notify/ChangeLog,v
retrieving revision 1.8
diff -u -p -r1.8 ChangeLog
--- ChangeLog	12 May 2005 04:27:39 -0000	1.8
+++ ChangeLog	8 Jul 2005 08:27:12 -0000
@@ -1,3 +1,11 @@
+2005-07-08  Vivek Jain  <jvivek novell com>
+	
+	* new-mail-notify.c :(send_dbus_message)
+	check whether memory could be allocated. Return if the 
+	message is NULL so that we don't unref it again.
+	**Fixes #274329 sort of bugs, in case reported even after 
+	david's fix.
+
 2005-05-11  Not Zed  <NotZed Ximian com>
 
 	* Makefile.am: added built_sources/cleanfiles
Index: new-mail-notify.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/new-mail-notify/new-mail-notify.c,v
retrieving revision 1.5
diff -u -p -r1.5 new-mail-notify.c
--- new-mail-notify.c	6 May 2005 09:24:11 -0000	1.5
+++ new-mail-notify.c	8 Jul 2005 08:27:12 -0000
@@ -57,6 +57,9 @@ send_dbus_message (const char *message_n
 					   DBUS_INTERFACE,
 					   message_name);
 
+	if (message == NULL) 
+		return;
+
 	/* Appends the data as an argument to the message */
 	dbus_message_append_args (message,
 #if DBUS_VERSION >= 310


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]