[evolution-patches] Re: patch to reduce bonobo calls for calendar

[chenthill <pchenthill novell com>]

On Thu, 2005-07-07 at 22:55 +0530, lviren wrote:
>     +static gboolean e_cal_get_read_only (ECal *ecal, gboolean *read_only, GError **error);
The static functions should not be declared in the header  file. The usage of the static gboolean variables is incorrect and it will not work. 

+               ecal->priv->cal_address = address;

The value must be duped here.

The notifications should not be sent in _open methods from the backend. The notifications should only be sent from the backend if the read only or cal_address values change in the backend. Please make sure the patch is tested before sending it.

thanks, chenthill.