Re: [evolution-patches] Proxy Login Patches

[Not Zed <notzed ximian com>]

> if (foo_bar) {
> 	if (foo) {
> 	/*blah*/
> 	/*blah_blah*/
> 	}
> }

Generally, dont add an if in an if if thats all it adds.
Instead do:

if (foo_ bar && foo) {
}

It'll make the patch a lot smaller too ;-)

> diff mistakes the level indentation as redundant white space (cos of the
> w option) and hence ignores it in the patch. Will keep that in mind next
> time.

Ok, i thought it looked funny.  Definitely always use just -Nup and
whatever -z option you normally use.

I have this in my .cvsrc so it runs by default with the right options.

notzed lostzed:~> cat ~/.cvsrc
cvs -z4
diff -Nup
update -dP

> > > @@ -486,6 +505,17 @@ e_account_set_from_xml (EAccount *accoun
> > >                                         }
> > >                                 }
> > >                         }
> > > +               } else if (!strcmp (node->name, "proxy")) {
> > > +                       if (node->children) {
> > > +                               for (cur = node->children; cur; cur =
> > > cur->next) {
> > > +                                       if (!strcmp (cur->name,
> > > "parent-source-url")) {
> > > +                                               changed |=
> > > xml_set_content (cur, &account->proxy_account->parent_url);
> > > +                                       } else if (!strcmp (cur->name,
> > > "parent-uid")) {
> > > +                                               changed |=
> > > xml_set_content (cur, &account->proxy_account->parent_uid);
> > > +                                               break;
> > > +                                       }
> > > +                               }
> > > +                       }
> > >                 }
> > 
> > Do you need to save these settings?  Dont they just need to be around at
> > runtime?  Do you need this to communicate the values around?  Aren't
> > they stored on the server anyway?
> > 
> > If they dont need to be saved, then you dont need to clear the proxies
> > on startup, and you just dont save them to gconf when they are created,
> > or need to handle loading them.  But if they are needed for
> > comminication then i guess there's not much that can be done about
> > it ...
> > 
> The Groupwise listener needs that to add corresponding ESources as you
> already guessed. 

Groan, ok!  Thats a bummer, makes a mess of things.  Someones really
gotta start looking at that unified account thing at some point.  Maybe
something I can look into.  I'd rather have a corba service which
managed the lists, even if it stored the actual data in gconf anyway.

> > > -
> > > -               /* let the rest of the application know it changed */
> > > +                               mail_config_remove_account_proxies
> > > (account);
> > > +                               gtk_widget_set_sensitive (GTK_WIDGET
> > > (prefs->mail_edit), 1);
> > 
> > Why are you changing the edit sensitivity here?  Can't you edit accounts
> > with proxies?  How do you add more proxies?  Aren't the proxy accounts
> > never listed in the first place?
> > 
> Nope, The account which has created proxies cannot be edited. The proxy
> addition as of now is through "right click" on the store. And i need to
> validate it as a menu entry since its only valid on "Groupwise
> Accounts".

Ok, I guess that makes sense, sort of (it sounds a bit confusing to me,
but if it works i guess its no big deal).

Thanks for the clarifications and good luck.