[evolution-patches] Re: Fix for 309684

[Ross Burton <ross burtonini com>]

On Thu, 2005-07-07 at 11:12 +0100, Ross Burton wrote:
> On Thu, 2005-07-07 at 09:42 +0100, Ross Burton wrote:
> > Attached is a patch for
> > http://bugzilla.gnome.org/show_bug.cgi?id=309684, where bookviews are
> > not unreferenced correctly and leak (resulting in the VM size of eds
> > growing massively by 8 meg per leak).
> 
> Sorry, this patch is causing entries to be double in the list...

Smaller patch which actually works.

Ross
-- 
Ross Burton                                 mail: ross burtonini com
                                          jabber: ross burtonini com
                                     www: http://www.burtonini.com./
 PGP Fingerprint: 1A21 F5B0 D8D0 CFE3 81D4 E25A 2D09 E447 D0B4 33DF

Index: libedataserverui/e-contact-store.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/libedataserverui/e-contact-store.c,v
retrieving revision 1.9
diff -u -r1.9 e-contact-store.c
--- libedataserverui/e-contact-store.c	6 Jul 2005 08:39:04 -0000	1.9
+++ libedataserverui/e-contact-store.c	7 Jul 2005 10:28:10 -0000
@@ -560,9 +560,10 @@
 	}
 
 	/* If current view finished, do nothing */
-	if (book_view == source->book_view)
+	if (book_view == source->book_view) {
+		stop_view (contact_store, source->book_view);
 		return;
-
+	}
 	g_assert (book_view == source->book_view_pending);
 
 	/* However, if it was a pending view, calculate and emit the differences between that