Re: [evolution-patches] Re: New hook for junk plugin (improved)

[Vivek Jain <jvivek novell com>]

Thank you for all the suggestions and comments.
I have committed it in CVS head.

Vivek Jain

On Tue, 2005-07-05 at 23:42 +0800, Not Zed wrote:
> The camel patch doesn't need to be so big, and you can save some
> processing too.
> 
> In camel-folder.c:folder_changed, you can just make this one line
> change:
> 
> 	CAMEL_FOLDER_UNLOCK(folder, change_lock);
> 
> ->	if (changed->uid_changed->len) {
> 		guint32 flags;
> 
> 		for (i = 0; i < changed->uid_changed->len; i ++) {
> 			flags = camel_folder_get_message_flags (folder,
> changed->uid_changed->pdata [i]);
> 			if (flags & CAMEL_MESSAGE_JUNK_LEARN) {
> 
> 
> Change the line with -> on it to:
> 	if (session->junk_plugin && changed->uid_changed->len) {
> 
> This will prevent the junk data from ever being setup in the first place
> and shortcut all of the subsequent processing (that whole block is only
> doing checks for junk processing).
> 
> The rest looks ready, but its 2005, not 2004 anymore :).
> 
> Please commit once the above change is made to the camel patch.
> 
> Thanks,
>  Michael
>