Re: [evolution-patches] (groupwise) minor changes in groupwise backend

[chenthill <pchenthill novell com>]

On Thu, 2005-06-30 at 23:54 -0600, Susarla Parthasarathi wrote:
>                }
>     +               } else if (!g_ascii_strcasecmp (name, "size")) {
>     +                       item->priv->size = atoi(soup_soap_parameter_get_string_value (child));
>       
 soup_soap_parameter_get_int_value can be used here.

+                                       e_gw_item_set_priority (item, value);
+                                       g_free (value), value = NULL;
+                               }
Please have the two statements one below the other instead of comma separation. 

 SoupSoapParameter *temp;
     EGwItemLinkInfo *info = g_new0 (EGwItemLinkInfo, 1);
+                       temp = soup_soap_parameter_get_first_child_by_name (child, "id") ;

Instead of using temp as a variable name, subparam can be used.


+e_gw_item_set_attach_status (EGwItem *item, gboolean has_attachment)
+{
+       g_return_if_fail (E_IS_GW_ITEM (item));

The above get and set functions for is not needed.

                	ref =  soup_soap_parameter_get_property (temp, "itemReference");
 					if (ref) {
-						attach->contentType = g_strdup_printf ("gw:%s",ref);
+						attach->item_reference = g_strdup (ref);
 						g_free (ref);
 					}
You can directly assign the ref instead of duping and freeing it.



- Chenthill.