Re: [evolution-patches] Patch to resize images

[Not Zed <notzed novell com>]

It still leaks at least one string, the cache refcounting is completely
wrong, and you're still calling object methods from a class to its child
class (this last is particulary serious - it will definitely break
printing and probably cause crashes too).  Despite all of those being
mentioned in previous reviews, or being obvious problems that shouldn't
need mentioning.

Please don't work on or submit another patch - I've already started
working on trying to fix this patch directly.  I'm tired of and
extremely frustrated about sending reviews that are mostly ignored, and
i'm sure you're tired of being told of your mistakes.

Thank you for the work so far though.

 Michael

On Mon, 2005-07-04 at 16:58 +0530, Srinivasa Ragavan wrote:
> I have attached a patch.
> On Fri, 2005-07-01 at 13:21 +0800, Not Zed wrote:
> > On Mon, 2005-06-27 at 15:27 +0530, Srinivasa Ragavan wrote:
> > > Hah, I hope i have worked on most of the comments...
> > > 
> > > - I have reused em-icon-stream