Re: [evolution-patches] Patch to fix anonymous nntp

[Not Zed <notzed ximian com>]

On Thu, 2005-01-27 at 07:37 -0500, Jeff Bailey wrote:
> When did the broken URIs start?  I thought it was in the 2.0 series, in
> which case this patch is needed to ensure smooth upgrades.  (The distros
> would be forced to pick it up anyway.)  Because the broken URI is used
> in finding the pieces in ~/.evolution, losing it could be a major
> inconvenience.

I doubt it occured in 2.0.  It should have only occured in 2.1 because the code was completely re-written there.

> It would probably be good to see this patch applied with a /* historical
> mistake, should never happen, but it did. */ comment attached to it.
>
> My 2¢.
>
> Tks,
> Jeff Bailey
>
> Le jeudi 27 janvier 2005 à 10:46 +0800, Not Zed a écrit :
> > 
> > Hmm, this should already be fixed.  The creation of the uri that is.
> > If the account was setup before hand though, it will still have the
> > old broken uri.
> > 
> > See:
> > 
> > http://bugzilla.ximian.com/show_bug.cgi?id=70990
> > 
> > I'd probably rather stick to that solution since it creates a proper
> > uri.
> > 
> > On Wed, 2005-01-26 at 07:40 -0500, Jeff Bailey wrote: 
> > > This patch allows anonymous nntp to work again.  The system creates the
> > > URIs as nntp://@news.gmane.org/, which cases the username to be an empty
> > > string rather than NULL.  I didn't patch the construction of the URI,
> > > since it seems that these are system internals and might lose
> > > configuration information if it changes suddenly.
> > > 
> > > 2005-01-22  Jeff Bailey <jbailey ubuntu com>
> > > 
> > >         * providers/nntp/camel-nntp-store.c
> > >           (connect_to_server): Allow the username to be an empty string
> > >           as well as a NULL for anonymous connections.
> > >