Re: [evolution-patches] patch for a11y bug of contact selector UI

[Hans Petter Jansson <hpj ximian com>]

> Attach is an a11y patch for evolution contact selector UI, include 
> adding accesskey and making gok work correctly.

The patch for e-contact-list-editor.c looks ok. As for the other patch:

In e-name-selector-dialog.c:

+       a11y = gtk_widget_get_accessible (section.destination_view);
+       if (a11y != NULL) {
+               gchar *text;
+               if (pango_parse_markup (pretty_name, -1, '_', NULL,
+                                       &text, NULL, NULL))  {
+               atk_object_set_name (a11y, text);
+               g_free (text);
+               }

The indenting of the inner scope here is bad.

In e-name-selector.c:

+               a11y = gtk_widget_get_accessible (GTK_WIDGET
(&section->entry->parent));

You don't need to use &section->entry->parent here, just use
section->entry. It's the same pointer offset.

-- 
Hans Petter Jansson | <hpj novell com>
Evolution Developer | http://hp.cl.no/