Re: [evolution-patches] patch to fix #71658



On Mon, 2005-01-24 at 16:38 +0800, Li Yuan wrote:
> Hi, Rodrigo
> 
> Here is a little patch to fix bugzilla #71658.
> http://bugzilla.ximian.com/show_bug.cgi?id=71658
> 
> Please help me to review it.

I think we need to decide about local variables and the a11y stuff.

I mentioned this a while ago and NotZed brought it up today, instead of:

+       a11y = gtk_widget_get_accessible (e_table);
+       if (a11y)
+               atk_object_set_name (a11y, _("Task Table"));

I think:

atk_object_set_name (gtk_widget_get_accessbile (e_table), _("Task Table"));

The only way this wouldn't work here afaict is that e_table is an
invalid widget or someone overrides the get_accessible method and
returns NULL.  This also saves us a local variable.

-JP
-- 
JP Rosevear <jpr novell com>
Novell, Inc.





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]