[evolution-patches] mail 64964, wrong button defaulting

[Not Zed <notzed ximian com>]

explained in changelog



Index: widgets/misc/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/widgets/misc/ChangeLog,v
retrieving revision 1.343
diff -u -p -r1.343 ChangeLog
--- widgets/misc/ChangeLog	17 Jan 2005 08:56:49 -0000	1.343
+++ widgets/misc/ChangeLog	20 Jan 2005 07:26:14 -0000
@@ -1,3 +1,12 @@
+2005-01-20  Not Zed  <NotZed Ximian com>
+
+	** See bug #64964.
+
+	* e-error.c (e_error_newv): just use add_button, not
+	add_action_widget, for stock+label widgets, since they both show
+	the same, and for some reason set_default_response doesn't work
+	otherwise.
+
 2005-01-17  Harry Lu  <harry lu sun com>
 
 	Fix for 62831.
Index: widgets/misc/e-error.c
===================================================================
RCS file: /cvs/gnome/evolution/widgets/misc/e-error.c,v
retrieving revision 1.15
diff -u -p -r1.15 e-error.c
--- widgets/misc/e-error.c	22 Dec 2004 07:37:51 -0000	1.15
+++ widgets/misc/e-error.c	20 Jan 2005 07:26:14 -0000
@@ -460,12 +460,16 @@ e_error_newv(GtkWindow *parent, const ch
 		for (b = e->buttons;b;b=b->next) {
 			if (b->stock) {
 				if (b->label) {
+#if 0
 					/* FIXME: So although this looks like it will work, it wont.
-					   Need to do it the hard way ... */
+					   Need to do it the hard way ... it also breaks the
+					   default_response stuff */
 					w = gtk_button_new_from_stock(b->stock);
 					gtk_button_set_label((GtkButton *)w, b->label);
 					gtk_widget_show(w);
 					gtk_dialog_add_action_widget(dialog, w, b->response);
+#endif
+					gtk_dialog_add_button(dialog, b->label, b->response);
 				} else
 					gtk_dialog_add_button(dialog, b->stock, b->response);
 			} else