Re: [evolution-patches] 47824, multipart messages re-using teh same boundary



looks good... but:

+       while ((state = camel_mime_parser_step(cmp, &buf, &len)) !=
CAMEL_MIME_PARSER_STATE_MULTIPART_END) {

what happens here if we get EOS for example? will things work out ok?

+               if (mps->start1 == -1) {
+                       head =
camel_mime_parser_tell_start_boundary(cmp);
+                       mps->start1 =
camel_mime_parser_tell_start_headers(cmp);
+               } else if (mps->start2 == -1) {
+                       mps->start2 =
camel_mime_parser_tell_start_headers(cmp);
+                       mps->end1 =
camel_mime_parser_tell_start_boundary(cmp);
+                       if (mps->end1 > mps->start1 &&
mem->buffer->data[mps->end1-1] == '\n')
+                               mps->end1--;
+                       if (mps->end1 > mps->start1 &&
mem->buffer->data[mps->end1-1] == '\r')
+                               mps->end1--;
+               } else {
+                       g_warning("multipart/signed has more than 2
parts, remaining parts ignored");
+                       break;
+               }

On Wed, 2005-01-12 at 16:32 +0800, Not Zed wrote:
> 
> this includes the 64 bit patches from a previous mail too, too hard to
> extract right now.
> 
> for stable, and same needs to go into head.
> 
> includes fixes for tests too.
> 
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com  - www.novell.com

Attachment: smime.p7s
Description: S/MIME cryptographic signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]