Re: [evolution-patches] Fix the lack of message reading signal in new mail notify plugin

[Not Zed <notzed ximian com>]

You should copy all the common code into a single function, you have a lot of duplication here (all the comments are wrong for starters).

Perhaps something like
send_dbus_message(const char *message_name, ...);
where .. are just the DBUS_TYPE things, assuming there is a dbus_message_append_args type function which takes a va_list.

Then your callbacks become one-liners to the function which does the work.

And also note that gconf_client_get_default() returns a ref'd object you need to unref after you're finished with it.

Cheers,
 Michael

On Wed, 2005-01-12 at 00:38 -0600, Miguel Angel López Hernández wrote:
> Hi,
>
> This patch fix the lack of a D-BUS signal when a message reading event
> is fired, this allow the apps to know when the user starts reading their
> mail.
>
> Greetings,
> Miguel

--

Michael Zucchi <notzed ximian com> "Ride, Work, Sleep. Beer." Novell's Evolution and Free Software Developer