Re: [evolution-patches] patch for combo-button's a11y bug

[Harry Lu <Harry Lu Sun COM>]

JP,
    Thanks a lot for the review. I changed the patch to use enum as you suggested and committed it into HEAD.
       Harry

JP Rosevear wrote:

On Wed, 2004-12-08 at 18:54 +0800, Harry Lu wrote:
  

+static void
+ea_combo_button_init (EaComboButton *a11y)
+{
+       /* Empty for new */
+}
    

"Empty for now" I presume.

Looks ok otherwise, except for the use of "magic" numbers for the
actions.  I think it would be better to do something like:

enum {
	ACTIVATE_DEFAULT,
	POPUP_MENU,	
	LAST_ACTION
};

then you can return LAST_ACTION in the get_num_actions routine and use
the others in the various case statements.

-JP