Re: Updated patch for 72668 (Was:Re: [evolution-patches] Patch to fix calendar printing with indic/Japanese scripts)

[Rodrigo Moya <rodrigo novell com>]

On Mon, 2005-02-21 at 21:33 -0500, David Malcolm wrote:
> On Mon, 2005-02-21 at 11:21 +0100, Rodrigo Moya wrote:
> >On Mon, 2005-02-14 at 23:14 -0500, David Malcolm wrote:
> >> The attached patch is a first pass at getting Evolution to use
> >> gnome_print_pango_layout when printing calendars.  This makes calendar
> >> printing work when using indic and Japanese scripts.  This is being
> >> tracked downstream here:
> >> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=138075
> >> 
> >> It's not quite ready to be committed yet, but I wanted feedback that I'm
> >> heading in the right direction with this.  I'll need to add a ChangeLog
> >> entry, and a configure.in test that sets up
> >> HAVE_GNOME_PRINT_PANGO_INTEGRATION appropriately (available in
> >> libgnomeprint from version 2.6 onwards, I believe).
> >> 
> >looks ok to me, although I don't like too much having so  much #ifdef'ed
> >code, but I guess there's no better way to do it.
> 
> I filed a proper BZ for the bug here:
> http://bugzilla.ximian.com/show_bug.cgi?id=72668
> 
> Attached is an updated version of the patch which assumes the presence
> of libgnomeprint >= 2.7.0, together with a patch for configure.in to
> require this.   Basically it takes the #ifdef versions of everything and
> uses that, together with the removal of some debug logging the old patch
> had.
> 
> So: (i) what do you think about the printing patch?
> (ii) is the requirements change (and hence the configure.in patch)
> acceptable?
> 
looks, codewise, good to me, although I can't test it, since I don't
have a printer :( So, if it works for you and neither JP nor Harish
disagree, please commit.
-- 
Rodrigo Moya <rodrigo novell com>