Re: [evolution-patches] Exchange : fix for 73079

[Sarfraaz Ahmed <asarfraaz novell com>]

Yeah, that was the problem. And it was true for online mode as well. So fixed it there too. Also found some duplicate declaration of refresh_folder in camel-exchange. So removed that as well. New patch attached.

Thanks
-- Sarfraaz

On Sun, 2005-02-27 at 14:37 +0530, Sushma Rai wrote:
> In offline mode, folders are getting unrefed 
> twice, may be that is the issue.
>
> -Sushma.
>
> >>> Sarfraaz Ahmed <asarfraaz novell com> 02/27/05 13:24 PM >>>
> Hi,
>
> The ref counts for the folders were not getting updated while moving
> from offline to online. This fixes that problem.
>
>             Thanks
>                                         -- Sarfraaz Ahmed
> <asarfraaz novell com>


Index: camel/camel-exchange-folder.c
===================================================================
RCS file: /cvs/gnome/evolution-exchange/camel/camel-exchange-folder.c,v
retrieving revision 1.14
diff -u -p -u -r1.14 camel-exchange-folder.c
--- camel/camel-exchange-folder.c	26 Feb 2005 14:19:15 -0000	1.14
+++ camel/camel-exchange-folder.c	27 Feb 2005 10:11:16 -0000
@@ -91,7 +91,6 @@ class_init (CamelFolderClass *camel_fold
 
 	/* virtual method definition */
 	camel_folder_class->sync = folder_sync;
-	camel_folder_class->refresh_info = refresh_info;
 	camel_folder_class->expunge = exchange_expunge;
 	camel_folder_class->append_message = append_message;
 	camel_folder_class->get_message = get_message;
Index: storage/exchange-hierarchy-webdav.c
===================================================================
RCS file: /cvs/gnome/evolution-exchange/storage/exchange-hierarchy-webdav.c,v
retrieving revision 1.25
diff -u -p -u -r1.25 exchange-hierarchy-webdav.c
--- storage/exchange-hierarchy-webdav.c	26 Feb 2005 14:19:16 -0000	1.25
+++ storage/exchange-hierarchy-webdav.c	27 Feb 2005 10:11:16 -0000
@@ -679,7 +679,6 @@ scan_subtree (ExchangeHierarchy *hier, E
 		for (i = 0; i <folders->len; i++) {
 			tmp = (EFolder *)folders->pdata[i];
 			exchange_hierarchy_new_folder (hier, (EFolder *)folders->pdata[i]);
-			g_object_unref (folders->pdata[i]); // is this needed ?
 		}
 		return EXCHANGE_ACCOUNT_FOLDER_OK;
 	}
@@ -708,7 +707,6 @@ scan_subtree (ExchangeHierarchy *hier, E
 			subtrees = g_slist_prepend (subtrees, folder);
 		}
 		exchange_hierarchy_new_folder (hier, folder);
-		g_object_unref (folder);
 	}
 	status = e2k_result_iter_free (iter);