[evolution-patches] Re: Exchange connector - patch for allowing account creation only after user authentication.

[Sushma Rai <rsushma novell com>]

Hi,

Committing this patch, after removing the change made to hostname check
condition, which anyway is same as what it was before.

Thanks,
Sushma.


On Sat, 2005-02-26 at 11:56 +0530, Sushma Rai wrote:
> Hi,
> 
> For exhange account setup, once the user enters user name the forward
> button gets enabled because page check returns success as we 
> initialize the hostname to "" in the plugin. 
> But we should allow user to proceed with account creation only after
> user gets authenticated, with the owa url value provided.
> 
> Please review the attached patch for this problem.
> 
> Thanks,
> Sushma.
> 
> 
> 

Index: exchange-account-setup.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/exchange-account-setup/exchange-account-setup.c,v
retrieving revision 1.10
diff -u -p -r1.10 exchange-account-setup.c
--- exchange-account-setup.c	23 Feb 2005 06:11:58 -0000	1.10
+++ exchange-account-setup.c	26 Feb 2005 07:34:06 -0000
@@ -375,7 +375,13 @@ org_gnome_exchange_check_options(EPlugin
 
 	/* We assume that if the host is set, then the setting is valid.
 	   The host gets set when the provider validate() call is made */
-	if (data->pageid == NULL || strcmp(data->pageid, "20.receive_options") == 0) {
+	/* We do this check for receive page also, so that user can
+	 * proceed with the account set up only after user is validated,
+	 * and host name is reset by validate() call
+	 */
+	if (data->pageid == NULL ||
+	    strcmp (data->pageid, "10.receive") == 0 ||
+	    strcmp (data->pageid, "20.receive_options") == 0) {
 		CamelURL *url;
 
 		url = camel_url_new(e_account_get_string(target->account,  E_ACCOUNT_SOURCE_URL), NULL);
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/plugins/exchange-account-setup/ChangeLog,v
retrieving revision 1.21
diff -u -r1.21 ChangeLog
--- ChangeLog	25 Feb 2005 15:54:20 -0000	1.21
+++ ChangeLog	26 Feb 2005 07:34:13 -0000
@@ -1,3 +1,10 @@
+2005-02-26  Sushma Rai  <rtsushma novell com>
+
+        * exchange-account-setup.c (org_gnome_exchange_check_options):
+        Returning FALSE on NULL host name or set to "" for receive page, 
+	so that one can proceed with the account creation only after 
+	hostname is retrived and set by validate().
+
 2005-02-24  Björn Torkelsson  <torkel acc umu se>
 
 	* org-gnome-exchange-account-setup.eplug.in: Added author and