Re: [evolution-patches] Exchange : Fix for 71519

[Sushma Rai <rsushma novell com>]

Quite a big  patch. A changelog entry would have helped in reviewing.

exchange_create_folder(): 
should return in case of offline. Uncomment that code.

get_message(): 
The message retuned by find_message() is ignored.

exchange_account_open_folder():
mode will be set to UNSUPPORTED_MODE in case 
EXCHANGE_IS_ACCOUNT (account) condition fails in
exchange_account_is_offline() function.
exchange_account_open_folder() already does that check.
so if (offline == UNSUPPORTED_MODE) becomes redundant.

scan_subtree():  
Offline check need to be done before calling get_hrefs().

Isn't it better to have a variable initialized to true or false, instead
of doing the comparison (offline == whatever mode ) everytime?

Thanks,
Sushma.



On Wed, 2005-02-23 at 12:29 +0530, Sarfraaz Ahmed wrote:
> Hi,
> 
> This fixes #71519 for mailer not showing messages in offline mode. I
> also found some bug in the offline listener code so added that too in
> this patch, as it is anyway needed for this bugfix.
> 
> 
>             Thanks
>                                         -- Sarfraaz Ahmed
> <asarfraaz novell com>