Re: [evolution-patches] 71373 Re-enabling first run wizard

[Not Zed <notzed ximian com>]

wizard_check:
 pageid can be null ('validate all pages'), can't strcmp it directly


#if !GTK_CHECK_VERSION (2,4,0)
	gtk_dialog_set_has_separator (GTK_DIALOG (dialog), FALSE);
#endif

simpler to use g_object_set(x, "separator", FALSE, NULL);


	import_page = GNOME_DRUID_PAGE (e_config_page_get (ec, "60.import"));

this is mis-spelt, it causes a crash in the wizard every time.

You shouldn't be changing the current druid page at all.  You really really must not be
jumping to the finish page from the page check function either - there could
be other pages from plugins.  Perhaps just show a label with "no data to
import" if there isn't any.  OR even better ... calculate whether you need to
show it in the widget factory, and don't ever generate any druid page in the
first place.  The intelligent importer list could safely be a global you only calculate once.

The commit unref() code looks very questionable.  You must leave it up to the druid to destroy it.

PS just make one patch next time, or build them all from the root - much
easier to apply and revert that way.

On Wed, 2005-02-23 at 22:50 -0500, JP Rosevear wrote:
> On Tue, 2005-02-22 at 10:50 +0800, Not Zed wrote:
> > 
> > i'd much rather you just added a 'const char *id' to
> > em_account_editor_new(), without this abdomination of a function name.

Hmm, odd, "config_id" != "id", why so much typing.

> > and made the em_account_editor_construct code static.
>
> Done and done.  Also made sure the strings used are exact so as not to
> break the string freeze and that the groupwise/exchange plugin
> definitions were updated.
>
> -JP