Re: [evolution-patches] patch for #70908 (address book)

[Sivaiah Nallagatla <snallagatla novell com>]

committed with doc string formatting fixed.

Siva
On Mon, 2005-02-21 at 17:15 -0600, Hans Petter Jansson wrote:
>On Sun, 2005-02-20 at 23:59 +0530, Sivaiah Nallagatla wrote:
>>This is a problem happens when a vcard has grouped attributes, for
>>exmple like
>>personal.EMAIL;TYPE=HOME;X-EVOLUTION-UI-SLOT=1:snallagatla novell com
>>personal.TEL;TYPE=HOME;TYPE=VOICE;X-EVOLUTION-UI-SLOT=2:12345
>>
>>We don't support grouping but we retain them when a vcard with that is
>>imported. e_vcard_remove_attributes does not remove an attribute when
>>passed in group name is NULL, but the attribute has a group name. When
>>we remove value of a multi attribute field  we always want to remove all
>>the attributes irrespective of group name they have. So i changed the
>>behaviour of the function as explained in code comment.
>
>Looks good, but the doc string you added needs some formatting:
>
>/**
> * e_vcard_remove_attributes:
> * @evc: VCard object
> * @attr_group: Group name of attributes to be removed
> * @attr_name: Name of the attributes to be removed
> *
> * Removes all the attributes with group name and attribute 
> * name equal to passed in values. If passed in group name is
> * NULL or an empty string, it removes all the attributes
> * with passed in name irrespective of their group names.
> **/
>
>Note how the function name is followed by ':' and arguments are prefixed
>with '@' and immediately followed by ':'. I also like to end the comment
>with "**/", as it begins with "/**", though I don't think that matters
>to the doc parser.
>