Re: [evolution-patches] Patch to fix calendar printing with indic/Japanese scripts

[David Malcolm <dmalcolm redhat com>]

On Mon, 2005-02-21 at 11:21 +0100, Rodrigo Moya wrote:
>On Mon, 2005-02-14 at 23:14 -0500, David Malcolm wrote:
>> The attached patch is a first pass at getting Evolution to use
>> gnome_print_pango_layout when printing calendars.  This makes calendar
>> printing work when using indic and Japanese scripts.  This is being
>> tracked downstream here:
>> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=138075
>> 
>> It's not quite ready to be committed yet, but I wanted feedback that I'm
>> heading in the right direction with this.  I'll need to add a ChangeLog
>> entry, and a configure.in test that sets up
>> HAVE_GNOME_PRINT_PANGO_INTEGRATION appropriately (available in
>> libgnomeprint from version 2.6 onwards, I believe).
>> 
>looks ok to me, although I don't like too much having so  much #ifdef'ed
>code, but I guess there's no better way to do it.

Agreed, it's really ugly.

If we can guarantee availability of a sufficiently recent libgnomeprint,
then we can do away with all of that.

I believe we'd need libgnomeprint>=2.7.0 for this.  Is this a reasonable
requirement for Evolution 2.1/2.2?