Re: [evolution-patches] Patch for getting Modified items [camel/groupwise]

[Vivek Jain <jvivek novell com>]

On Thu, 2005-02-10 at 14:27 +0530, Sivaiah Nallagatla wrote:
> You don't need a second varibale "second_list" list there. You can use
> slist itslef.
> Also those lists are not getting freed.
> 
> Siva

Thanks, for the review comments, sending the patch again with the
suggested changes.
Vivek

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/ChangeLog,v
retrieving revision 1.18
diff -u -p -r1.18 ChangeLog
--- ChangeLog	9 Feb 2005 08:28:26 -0000	1.18
+++ ChangeLog	10 Feb 2005 09:56:29 -0000
@@ -1,3 +1,12 @@
+2005-02-10  Vivek Jain  <jvivek novell com>
+	
+	* camel-groupwise-store.c: 
+	(groupwise_get_folder):
+	* camel-groupwise-folder.c
+	(groupwise_refresh_info):	
+	get the "Modified" items in the second_list and
+	append it to the "list"
+
 2005-02-09  Vivek Jain  <jvivek novell com>
 
 	* camel-groupwise-store.c:
Index: camel-groupwise-store.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/camel-groupwise-store.c,v
retrieving revision 1.28
diff -u -p -r1.28 camel-groupwise-store.c
--- camel-groupwise-store.c	9 Feb 2005 08:24:27 -0000	1.28
+++ camel-groupwise-store.c	10 Feb 2005 09:56:30 -0000
@@ -553,6 +553,7 @@ groupwise_get_folder (CamelStore *store,
 		status = e_gw_connection_get_quick_messages (priv->cnc, container_id,
 				"distribution attachments subject created",
 				time_string, "New", "Mail", NULL, -1, &slist) ;
+		
 		if (status != E_GW_CONNECTION_STATUS_OK) {
 			//camel_exception_set (ex, CAMEL_EXCEPTION_SERVICE_INVALID, _("Authentication failed"));
 			CAMEL_SERVICE_UNLOCK (gw_store, connect_lock) ;
@@ -565,10 +566,23 @@ groupwise_get_folder (CamelStore *store,
 			return folder ;
 			//return NULL ;
 		}
+	
+		for ( sl = slist ; sl != NULL; sl = sl->next) {
+			list = g_list_append (list, sl->data) ;
+		}
+
+		g_slist_free (slist);
+		slist = NULL;
+		if (e_gw_connection_get_quick_messages (priv->cnc, container_id,
+					"distribution attachments subject created",
+					time_string, "Modified", "Mail", NULL, -1, &slist) == E_GW_CONNECTION_STATUS_OK) 
 
 		for ( sl = slist ; sl != NULL; sl = sl->next) {
 			list = g_list_append (list, sl->data) ;
 		}
+		
+		g_slist_free (slist);
+		slist = NULL;
 		gw_update_summary (folder, list,  ex) ;
 		camel_operation_end (NULL);
 
Index: camel-groupwise-folder.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/camel/providers/groupwise/camel-groupwise-folder.c,v
retrieving revision 1.23
diff -u -p -r1.23 camel-groupwise-folder.c
--- camel-groupwise-folder.c	8 Feb 2005 08:17:26 -0000	1.23
+++ camel-groupwise-folder.c	10 Feb 2005 09:56:30 -0000
@@ -484,7 +484,8 @@ groupwise_sync (CamelFolder *folder, gbo
 	flags_diff_t diff ;
 	//EGwConnection *cnc = cnc_lookup (priv) ;
 	int count, i ;
-	g_print ("groupwise sync\n") ;
+	g_print ("groupwise sync\n");
+
 	if (((CamelOfflineStore *) gw_store)->state == CAMEL_OFFLINE_STORE_NETWORK_UNAVAIL) 
 		return ;
 	
@@ -636,8 +637,17 @@ groupwise_refresh_info(CamelFolder *fold
 	
 	for ( sl = slist ; sl != NULL; sl = sl->next) {
 		list = g_list_append (list, sl->data) ;
+	}	
+	g_slist_free (slist);
+	slist = NULL;
+	if (e_gw_connection_get_quick_messages (cnc, container_id,
+				"distribution created attachments subject",
+				time_string, "Modified", "Mail", NULL, -1, &slist) == E_GW_CONNECTION_STATUS_OK)
+		for ( sl = slist ; sl != NULL; sl = sl->next) {
+		list = g_list_append (list, sl->data) ;
 	}
-
+	g_slist_free (slist);
+	slist = NULL;
 	if (gw_store->current_folder != folder) {
 		gw_store->current_folder = folder ;
 	} else if(gw_folder->need_rescan) {
@@ -1136,7 +1146,7 @@ convert_to_calendar (EGwItem *item, char
 			    NULL ) ;
 
 	*len = strlen (*str) ;
-	
+
 	if (temp && strlen(temp))
 		g_free (temp) ;
 	g_strfreev (tmp);