Re: [evolution-patches] Mailer Context Menus Patch

[Luis Villa <luis villa gmail com>]

I'm fairly uncomfortable with making such a high-visibility change so
late in the cycle- where are the doc resources coming from to make
sure this is documented?

Luis


On Thu, 03 Feb 2005 12:18:51 -0500, Rodney Dawes <dobey novell com> wrote:
> Release Team,
> 
> This patch breaks UI freeze, and we need your approval to commit it.
> It greatly improves the usability of the context menus in Evolution,
> as it reduces the size. Please approve this patch so we can commit
> it before String Freeze on Monday. The patch is approved by appropriate
> Evolution module maintainers. Thanks.
> 
> -- dobey
> 
> PS: The patch is attached again for convenience to the release team.
> PSS: Replies to NotZed are in-line below.
> 
> On Thu, 2005-02-03 at 16:46 +0800, Not Zed wrote:
> >
> > Thanks for dealing with the issues, i'm happy with this now, please
> > commit this.
> 
> Thanks. It needs release-team approval though, since it breaks UI
> freeze.
> 
> > FWIW the 'quoted reply' thing could just be another big on em-popup
> > (well you have to have 2 bits, a 'selected text' and 'not selected
> > text', so each one is used to turn on the different labels - the
> > actual callbacks should be the same i think).  Or maybe the code to do
> > that was what you were referring to ...
> 
> Yeah. I was doing it with bits, but having it call the same code as the
> standard "Reply", with different context in the message list and
> display, just didn't seem right, and I didn't want to duplicate the code
> in the reply functions.
> 
> > On Wed, 2005-02-02 at 15:59 -0500, Rodney Dawes wrote:
> > > Here's a new patch. It does what you want for having one menu tree
> > > structure, and doesn't patch e-popup.c. I removed the "Quoted Reply"
> > > bits, because to do it right means duplicating a little bit of code,
> > > and I don't feel it's worth that much trouble to do it all the way
> > > right, right now, since this has to go in by Monday, ideally. Anyway,
> > > this new patch should satisfy all your quarrels. Thanks.
> > >
> > > -- dobey
> > >
> 
> 
> _______________________________________________
> release-team mailing list
> release-team gnome org
> http://mail.gnome.org/mailman/listinfo/release-team
> 
> 
> 
>