Re: [evolution-patches] [Calendar] Fix for Bug 303193

[Johnny Jacob <johnnyjacob gmail com>]

Hi
Reworked the patch. The bug is because of
http://mail.gnome.org/archives/gtk-devel-list/1998-November/msg00058.html

Inside the snooze_pressed_cb, grab the keyboard focus from the spin
button, which will update the changed value.

Please review and comment

Thanks
Johnny

On 12/20/05, chen <pchenthill novell com> wrote:
> Hi,
>         This does not fix the bug. Pressing the Alt+S with the focus at the
> spin button's text, the snooze time taken is the default and not the
> entered one.
>
>
> thanks, Chenthill.
>
> On Sat, 2005-12-17 at 16:24 +0530, Johnny Jacob wrote:
> > HI
> > Worked on Bug 303193: Changing reminder snooze time doesn't work after
> > pressing ALT-S.
> >
> > Please review the patch.
> >
> > Thanks
> > Johnny
> > _______________________________________________
> > Evolution-patches mailing list
> > Evolution-patches gnome org
> > http://mail.gnome.org/mailman/listinfo/evolution-patches
>

Index: calendar/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2899
diff -u -p -r1.2899 ChangeLog
--- calendar/ChangeLog	21 Dec 2005 04:13:33 -0000	1.2899
+++ calendar/ChangeLog	21 Dec 2005 10:07:35 -0000
@@ -1,3 +1,11 @@
+2005-12-21  Johnny Jacob  <johnnyjacob gmail com>
+
+	Fixes #303193
+	* gui/alarm-notify/alarm-notify-dialog.c (notified_alarms_dialog_new):
+	Changed events handled for edit_btn, snooze_btn from pressed to
+	clicked
+	(snooze_pressed_callback) : Grab keyboard focus to snooze_btn.
+
 2005-12-20  Chenthill Palanisamy  <pchenthill novell com>
 
 	Fixes #324525
Index: calendar/gui/alarm-notify/alarm-notify-dialog.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/alarm-notify/alarm-notify-dialog.c,v
retrieving revision 1.39
diff -u -p -r1.39 alarm-notify-dialog.c
--- calendar/gui/alarm-notify/alarm-notify-dialog.c	26 Nov 2005 02:31:51 -0000	1.39
+++ calendar/gui/alarm-notify/alarm-notify-dialog.c	21 Dec 2005 10:08:07 -0000
@@ -170,6 +170,8 @@ snooze_pressed_cb (GtkButton *button, gp
 	AlarmFuncInfo *funcinfo = NULL;
 	GtkTreeSelection *selection = gtk_tree_view_get_selection (GTK_TREE_VIEW (an->treeview));
 
+	gtk_widget_grab_focus (button);
+
 	if (gtk_tree_selection_get_selected (selection, &model, &iter))
 		gtk_tree_model_get (model, &iter, ALARM_FUNCINFO_COLUMN, &funcinfo, -1);	
 
@@ -276,8 +278,8 @@ notified_alarms_dialog_new (void)
 	gtk_image_set_from_file (GTK_IMAGE (image), icon_path);
 	g_free (icon_path);
 
-	g_signal_connect (edit_btn, "pressed", G_CALLBACK (edit_pressed_cb), an);
-	g_signal_connect (snooze_btn, "pressed", G_CALLBACK (snooze_pressed_cb), an);
+	g_signal_connect (edit_btn, "clicked", G_CALLBACK (edit_pressed_cb), an);
+	g_signal_connect (snooze_btn, "clicked", G_CALLBACK (snooze_pressed_cb), an);
 	g_signal_connect (G_OBJECT (an->dialog), "response", G_CALLBACK (dialog_response_cb), an);
 	g_signal_connect (G_OBJECT (an->dialog), "destroy", G_CALLBACK (dialog_destroyed_cb), an);