Re: [evolution-patches] fix for the bug #267330 [calendar]

[Harish Krishnaswamy <kharish novell com>]

Looks good to commit.

thanks,
Harish
On Fri, 2005-12-16 at 13:30 +0530, chen wrote:
> Hi,
>    Have attached a revised fix.
> 
> thanks, Chenthill.
> 
> 
> On Thu, 2005-12-01 at 03:16 -0500, Veerapuram Varadhan wrote:
> > On Wed, 2005-11-30 at 13:48 +0000, chen  wrote:
> > >  
> > > +       /* initialize */
> > > +       dtstart.tzid = NULL;
> > > +       dtstart.value = NULL;
> > > +       dtend.tzid = NULL;
> > > +       dtend.value = NULL;
> > > + 
> > 
> > I would suggest these changes in the e_cal_component_get_(dtstart/dtend)
> > APIs in e-d-s itself, instead of doing this initialization in all the
> > places.
> > 
> > Also, I guess, the general convention of any "get" method/function is to
> > return a proper value on success and "NULL"/equivalent on failure.
> > 
> > V. Varadhan
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches