Re: [evolution-patches] [NOSIP] Fix for Bug #320210 [Calendar]

[Srinivasa Ragavan <sragavan novell com>]

Fejj,

Im not sure about this. For the first accidental delete only you have a
confirmation, and you want to make sure, that user has to focus and
press OK again? I was looking into similar tasks in nautilus, and trying
to find out on this and thought this should be fine. Nautilus defaults
to OK. 

Any way, if people really thing this has to be done, i guess we can
revert. Good you came early, before we takeover on other dialogs as
well :-)

Thanks
Srini.
On Wed, 2005-12-14 at 11:35 -0500, Jeffrey Stedfast wrote:
> should "delete" confirmation dialogs always default to NO!?!? I mean,
> you are supposed to err on the side of caution... if the user is
> accidently clicks Enter, bam, his very important info is gone.
> 
> Jeff
> 
> On Wed, 2005-12-14 at 13:54 +0530, Johnny Jacob wrote:
> > Hi,
> > Worked on Bug 320210: make calendar item delete dialog default to yes.
> > 
> > Just changed the default button to GTK_RESPONSE_YES instead of GTK_RESPONSE_NO.
> > 
> > Please review the patch
> > 
> > Thankyou
> > Johnny
> > 
> > Index: calendar/ChangeLog
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
> > retrieving revision 1.2854
> > diff -u -p -r1.2854 ChangeLog
> > --- calendar/ChangeLog  25 Nov 2005 13:19:16 -0000      1.2854
> > +++ calendar/ChangeLog  28 Nov 2005 16:11:43 -0000
> > @@ -1,3 +1,8 @@
> > +2005-11-28  Johnny Jacob  <johnnyjacob gmail com>
> > +
> > +       * calendar.error.xml : Default button is changed to GTK_RESPONSE_YES
> > +       in "prompt-delete-titled-appointment".
> > +
> >  2005-11-25  Tor Lillqvist  <tml novell com>
> > 
> >         * gui/calendar-component.c (ensure_sources)
> > Index: calendar/calendar.error.xml
> > ===================================================================
> > RCS file: /cvs/gnome/evolution/calendar/calendar.error.xml,v
> > retrieving revision 1.5
> > diff -u -p -r1.5 calendar.error.xml
> > --- calendar/calendar.error.xml 19 Oct 2005 11:38:14 -0000      1.5
> > +++ calendar/calendar.error.xml 28 Nov 2005 16:11:49 -0000
> > @@ -43,7 +43,7 @@
> >    <button stock="gtk-delete" response="GTK_RESPONSE_YES"/>
> >   </error>
> > 
> > - <error id="prompt-delete-titled-appointment" type="question"
> > default="GTK_RESPONSE_NO">
> > + <error id="prompt-delete-titled-appointment" type="question"
> > default="GTK_RESPONSE_YES">
> >    <_primary>Are you sure you want to delete the appointment titled
> > '{0}'?</_primary>
> >    <_secondary>All information on this appointment will be deleted and
> > can not be restored.</_secondary>
> >    <button stock="gtk-cancel" response="GTK_RESPONSE_NO"/>
> > _______________________________________________
> > Evolution-patches mailing list
> > Evolution-patches gnome org
> > http://mail.gnome.org/mailman/listinfo/evolution-patches