Re: [evolution-patches] [exchange connector] fix for validation during autoconfig

[Sushma Rai <rsushma novell com>]

Looks good, Please commit.

Thanks,
-Sushma

On Mon, 2005-12-12 at 15:17 +0800, Irene Huang wrote:
> Hi, sush
> 
> Here's the updated patch. Can I commit it now? 
> 
> Thanks 
> 
> --Irene 
> 
> On Sat, 2005-12-10 at 18:17, Sushma Rai wrote:
> > I am not sure what problem will be fixed by this patch,
> > because there is already a check       
> > if (password && !valid) {
> > 	e_passwords_forget_password ("Exchange", key);
> > }
> > which is now moved inside if (password) condition, which will
> > make the code look good, thats all.
> > And key has to be freed even in case of remembered password.
> > 
> > Am I missing something?
> > 
> > -Sushma.
> > 
> > Which what 
> > 
> > On Fri, 2005-12-09 at 11:52 +0800, Irene Huang wrote:
> > > Hi, Exchange developers
> > > 
> > > 	I found that when we are reconfiguring an exchange account, clicking
> > > the authenticate button on the "receiving email" tab will trigger very
> > > strange behaviors. When the password is saved before, evolution tries to
> > > forget the password word and an error dialog emerges, only when the
> > > password is not saved can a dialog be popped up asking the users for
> > > input. 
> > > 
> > > 	I  created a patch for this bug, please reviews.
> > > 
> > > Thanks 
> > > 
> > > --Irene
> > > _______________________________________________
> > > Evolution-patches mailing list
> > > Evolution-patches gnome org
> > > http://mail.gnome.org/mailman/listinfo/evolution-patches
> > _______________________________________________
> > Evolution-patches mailing list
> > Evolution-patches gnome org
> > http://mail.gnome.org/mailman/listinfo/evolution-patches