Re: [evolution-patches] fix for the bug #267330 [calendar]

[Harish Krishnaswamy <kharish novell com>]

Chen,

 
> /* initialize */
> +       dt_start.tzid = NULL;
> +       dt_start.value =NULL;
> +       dt_end.tzid = NULL;
> +       dt_end.value = NULL:

I feel 
                    ECalComponentDateTime dt_start = {0};

 is shorter, safer and more elegant.



> @@ -948,10 +954,6 @@ event_page_fill_widgets (CompEditorPage 
>         clear_widgets (epage);
>  
>         /* Summary, location, description(s) */
> -
> -       /* Component for cancellation */
> -       priv->comp = e_cal_component_clone (comp);
> -       
>         e_cal_component_get_summary (comp, &text);
I guess, the above change is unrelated to the rest of the patch - some
cruft from your working copy? 
The rest is fairly straightforwards and fine to commit.

thanks.
harish

On Wed, 2005-11-30 at 19:18 +0530, chen wrote:
> Hi, 
>    Have attached the fix for the bug. Initialized the elements of the
> structure, so that it does not cause a crash. 
> 
> thanks, Chenthill.
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches