[evolution-patches] [Mail]Patch fix for #323253



hi all,

	that's patch for #323253,  evolution send & receive dialog would
display the String "Server: , Type:mbox" if url->host == "" in
format_url(), this patch do a change on checking whether url->host ==
NULL or url->host's length == 0 to avoid this.

	could someone help me to review them?

thanks,

jerry
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/mail/ChangeLog,v
retrieving revision 1.3704.2.7
diff -u -p -r1.3704.2.7 ChangeLog
--- ChangeLog	29 Sep 2005 08:44:08 -0000	1.3704.2.7
+++ ChangeLog	5 Dec 2005 09:59:02 -0000
@@ -1,3 +1,11 @@
+2005-12-05  Shi Pu  <shi pu sun com>
+
+	See bug ** 323253
+	
+	* mail-send-recv.c: (format_url):
+	If url->host is NULL or it's length equals zero,
+	don't print it out in send & receive dialog.
+
 2005-09-29  Parthasarathi Susarla <sparthasarathi novell com>
 	
 	** See bug 317284
Index: mail-send-recv.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-send-recv.c,v
retrieving revision 1.101
diff -u -p -r1.101 mail-send-recv.c
--- mail-send-recv.c	16 Aug 2005 03:39:19 -0000	1.101
+++ mail-send-recv.c	5 Dec 2005 09:59:05 -0000
@@ -261,7 +261,7 @@ format_url(const char *internal_url)
        	char *pretty_url;
 
 	url = camel_url_new(internal_url, NULL);
-	if (url->host)
+	if (url->host && strlen(url->host))
 		pretty_url = g_strdup_printf(_("Server: %s, Type: %s"), url->host, url->protocol);
 	else if (url->path)
 		pretty_url = g_strdup_printf(_("Path: %s, Type: %s"), url->path, url->protocol);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]