Re: [evolution-patches] [Mailer]Camel Patch fix #321139 for evolution-data-server

[Jeffrey Stedfast <fejj novell com>]

The code should not be requesting a description from an exception
variable without having first checked that the exception was set.

This fix is really just a kludge around broken code at a higher level.

Jeff

On Fri, 2005-12-02 at 16:56 +0800, Harry Lu wrote:
> Patch committed into cvd HEAD and gnome-2-12 branch with suggested changes.
> Thanks!
> 
>        Harry
> Parthasarathi Susarla wrote:
> 
> >Hey jerry,
> >The patch looks fine, It would be better to have the message as "No
> >description available" instead of "No exception description"
> >
> >Cheers,
> >partha
> >On Thu, 2005-12-01 at 18:01 +0800, jerrypu wrote:
> >  
> >
> >>Dear all,
> >>
> >>this patch fix #321139. Evolution would crash because of printing a NULL
> >>pointer receiving from camel_exception_get_description(). If param of
> >>camel_exception_get_description(CamelException *ex) is NULL, this func
> >>would return a NULL pointer. This patch do a change on the return value
> >>and avoid it.
> >>
> >>Anybody who can review it for me?
> >>
> >>Thanks,
> >>
> >>jerry
> >>_______________________________________________
> >>Evolution-patches mailing list
> >>Evolution-patches gnome org
> >>http://mail.gnome.org/mailman/listinfo/evolution-patches
> >>    
> >>
> >
> >_______________________________________________
> >Evolution-patches mailing list
> >Evolution-patches gnome org
> >http://mail.gnome.org/mailman/listinfo/evolution-patches
> >
> >  
> >
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches gnome org
> http://mail.gnome.org/mailman/listinfo/evolution-patches
> 
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com  - www.novell.com