Re: [evolution-patches] evolution-data-server, libedataserver/e-component-listener.c build failed

[Harish Krishnaswamy <kharish novell com>]

On Fri, 2005-11-18 at 20:38 +0800, Irene wrote:
> Hi, Harish 
> 
>         When I was trying to build the newest code of evolution data
> server
> (Head), the process failed with e-component-listener.c, because
> G_DEFINE_TYPE is now used to implement EComponentListener without
> removing the original declarations of e_component_listener_class_init,
> e_component_listener_init and e_component_listener_finalize. 
> 
>         Second, in the definition of e_component_listener_init, only 
> the first parameter should be used instead of two. 
>  
Right - this code was moved from evolution/e-util which did(does) not
use 
G_DEFINE_TYPE. I assume this still may be the case in a few other places
- we need to look out for them and fix them as well. 
Yet another catch on Solaris that Linux lets through  :-).


>         Third, e_component_listener_finalized should be moved before
> e_component_listener_class_init because it is invoked in that function. 
> 
referenced is perhaps the more apt than 'invoked' .
>         I created a patch for your kind review. 


Good patch.. Fine to commit.

Thanks,
Harish