[evolution-patches] 314701, crash posting to local folder



Not really something a user should do, but if they do then it hits some
negligent code in the composer.  Easy simple fix at least.


Index: composer/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/composer/ChangeLog,v
retrieving revision 1.714
diff -u -p -r1.714 ChangeLog
--- composer/ChangeLog	24 Aug 2005 04:19:01 -0000	1.714
+++ composer/ChangeLog	29 Aug 2005 05:17:42 -0000
@@ -1,3 +1,10 @@
+2005-08-29  Not Zed  <NotZed Ximian com>
+
+	** See bug #314701.
+
+	* e-msg-composer-hdrs.c (get_account_store_url): don't dereference
+	a null url or create an empty one.
+
 2005-08-22  Srinivasa Ragavan <sragavan novell com>
 
 	* e-msg-composer.c (drop_action): Show the bar depending on the 
Index: composer/e-msg-composer-hdrs.c
===================================================================
RCS file: /cvs/gnome/evolution/composer/e-msg-composer-hdrs.c,v
retrieving revision 1.143
diff -u -p -r1.143 e-msg-composer-hdrs.c
--- composer/e-msg-composer-hdrs.c	24 Aug 2005 03:08:37 -0000	1.143
+++ composer/e-msg-composer-hdrs.c	29 Aug 2005 05:17:43 -0000
@@ -1281,8 +1281,10 @@ get_account_store_url (EMsgComposerHdrs 
 	CamelURL *url;
 	char *ret = NULL;
 	
-	if (hdrs->account->source && hdrs->account->source->url) {
-		url = camel_url_new (hdrs->account->source->url, NULL);
+	if (hdrs->account->source
+	    && hdrs->account->source->url
+	    && hdrs->account->source->url[0]
+	    && (url = camel_url_new (hdrs->account->source->url, NULL))) {
 		ret = camel_url_to_string (url, CAMEL_URL_HIDE_ALL);
 		camel_url_free (url);
 	}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]