Re: [evolution-patches] Addressbook, calendar and exchange patch

[Christian Kellner <gicmo xatom net>]

Hi!

(WARNING, rant mode is on)

I totally appreciate the efforts to unify the password handling across
components, but again I think implementing quick and dirty URI parsing
in various places is the damn wrong way. Please look at my comment on
this thread [1] and NotZed's follow up. Despite the fact that I think
using g_strsplit for that is not The Right Way[tm] it's duplicated code
all over the place, might not catch all cases. Why don't you just use
EUri. That's what it's for. Consider the case
"gicmo gicmo org;auth=plain/password hula com:8080/Foo". What does the
various functions you changed return, e.g. build_pass_key (), after you
patch. If I am not wrong it's going to be "gicmo gnome org". Is that
really what you want out of that function? Actually what do you want to
get out of this function - this seriously needs some comments! You
changed that logic now 2 times in one week and only 3 days to hard code
freeze now. Also you obsolete the get_host_from_uri () function that you
introduced with the patch on Tuesday.

Sorry about the rant, but I honestly feel that I am not taken seriously
here. I am willing to write the patch with EUri if you tell me what you
the actually want to have as auth key.

Greetings and keep on rocking!
Christian

[1] "Re: [evolution-patches] calendar patch for 309420"