Re: [evolution-patches] Exchange, plugin - sets linestatus properly

[Sarfraaz Ahmed <asarfraaz novell com>]

Looks good. Please make the changes below and commit.

Thanks
-- Sarfraaz

On Thu, 2005-08-25 at 07:10 -0600, S Arun wrote:
> Hi,
> 
> Attached patch sets the linestatus
> properly.
> 

> Index: plugins/exchange-operations/exchange-config-listener.c
> ===================================================================

> 2005 13:04:14 -0000
> @@ -650,10 +650,14 @@ account_added (EAccountList *account_lis

>         }
> +
> +       exchange_account_set_online (exchange_account);
>  
>         result = exchange_config_listener_authenticate
> (config_listener, exchange_account);

We need not authenticate in account_added here. The plugins need to
authenticate only when needed, which needs to be done in
exchange-operations while fetching the ExchangeAccount. Also, make sure
that the error reporting routine is moved there.

>         if (result != EXCHANGE_ACCOUNT_CONNECT_SUCCESS)
> Index: plugins/exchange-operations/exchange-operations.c
> ===================================================================


>                         /* Try authenticating */
>                         result =
> exchange_config_listener_authenticate(exchange_global_config_listener,
> account);

Report errors here if authentication failed as said above.

>                         if (exchange_account_get_context (account))
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
>