Re: [evolution-patches] patch to fix a gal bug #314352

[Li Yuan <Li Yuan Sun COM>]

Hi Kaushal,

I have tested the code and it works. I think it is the best way to fix 
this bug.
Will you commit the patch or you want me to commit it?

Thanks,
Li

Kaushal Kumar wrote:

> Hi Li,
>
> I am attaching a simplified version of your patch since I found the else
> blocks were redundant. Please have a look and tell me if it fits into
> the need.
> Then it means, we enable horizontal cursor movement if either
> accessibility is enabled or eti->cursor_mode is not E_CURSOR_LINE
> (assuming other 2 conditions are true). I am not very clear on this.
> Could you please clarify for me.
> Thanks,
> Kaushal
>
>  
>
> > > > Li Yuan <Li Yuan Sun COM> 08/24/05 13:50 PM >>>
> > > >        
> Hi Kaushal,
>
> Now I have a patch to fix #*314352 *on bugzilla. Can you spend a little
> time to review it?
> It is an a11y bug, and it will not affect the existed code.
> I know there will be a code freeze on Aug 29th, should we make this
> patch in gnome 2.12?
>
> Thank you very much.
>
> Best Regards,
> Li
>
>
>  
>
> ------------------------------------------------------------------------
>
> --- e-table-item.c.orig	2005-08-24 14:31:15.000000000 +0530
> +++ e-table-item.c	2005-08-24 14:36:35.000000000 +0530
> @@ -2646,7 +2646,9 @@ eti_event (GnomeCanvasItem *item, GdkEve
> 			
> 			g_signal_emit (eti, eti_signals [KEY_PRESS], 0,
> 				       model_to_view_row(eti, cursor_row), cursor_col, e, &return_val);
> -			if ((!return_val) && eti->cursor_mode != E_CURSOR_LINE && cursor_col != view_to_model_col(eti, 0))
> +			if ((!return_val) &&
> +			   (atk_get_root() || eti->cursor_mode != E_CURSOR_LINE) &&
> +			   cursor_col != view_to_model_col(eti, 0))
> 				eti_cursor_move_left (eti);
> 			return_val = 1;
> 			break;
> @@ -2660,7 +2662,9 @@ eti_event (GnomeCanvasItem *item, GdkEve
>
> 			g_signal_emit (eti, eti_signals [KEY_PRESS], 0,
> 				       model_to_view_row(eti, cursor_row), cursor_col, e, &return_val);
> -			if ((!return_val) && eti->cursor_mode != E_CURSOR_LINE && cursor_col != view_to_model_col(eti, eti->cols - 1))
> +			if ((!return_val) &&
> +			   (atk_get_root() || eti->cursor_mode != E_CURSOR_LINE) &&
> +			   cursor_col != view_to_model_col(eti, eti->cols - 1))
> 				eti_cursor_move_right (eti);
> 			return_val = 1;
> 			break;
>