[evolution-patches] patch to fix a gal bug #314352



Hi Kaushal,

Now I have a patch to fix #*314352 *on bugzilla. Can you spend a little
time to review it?
It is an a11y bug, and it will not affect the existed code.
I know there will be a code freeze on Aug 29th, should we make this
patch in gnome 2.12?

Thank you very much.

Best Regards,
Li

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/widgets/table/ChangeLog,v
retrieving revision 1.5
diff -u -r1.5 ChangeLog
--- ChangeLog	24 Aug 2005 03:10:29 -0000	1.5
+++ ChangeLog	24 Aug 2005 08:02:23 -0000
@@ -1,3 +1,10 @@
+2005-08-24  Li Yuan  <li yuan sun com>
+
+	Fixes #314352.
+	* e-table-item.c: (eti_event):
+	 if accessibility is enabled, we enable horizontal cusor 
+	 movement for line selection.
+
 2005-08-23  Not Zed  <NotZed Ximian com>
 
 	* e-table-config.c (setup_fields): fix some missing casts.
Index: e-table-item.c
===================================================================
RCS file: /cvs/gnome/evolution/widgets/table/e-table-item.c,v
retrieving revision 1.242
diff -u -r1.242 e-table-item.c
--- e-table-item.c	23 Jun 2005 09:11:10 -0000	1.242
+++ e-table-item.c	24 Aug 2005 08:02:29 -0000
@@ -2646,7 +2646,11 @@
 			
 			g_signal_emit (eti, eti_signals [KEY_PRESS], 0,
 				       model_to_view_row(eti, cursor_row), cursor_col, e, &return_val);
-			if ((!return_val) && eti->cursor_mode != E_CURSOR_LINE && cursor_col != view_to_model_col(eti, 0))
+
+			if (atk_get_root () != NULL) {
+				if ((!return_val) && cursor_col != view_to_model_col(eti, 0))
+					eti_cursor_move_left (eti);
+			} else	if ((!return_val) && eti->cursor_mode != E_CURSOR_LINE && cursor_col != view_to_model_col(eti, 0))
 				eti_cursor_move_left (eti);
 			return_val = 1;
 			break;
@@ -2660,7 +2664,10 @@
 
 			g_signal_emit (eti, eti_signals [KEY_PRESS], 0,
 				       model_to_view_row(eti, cursor_row), cursor_col, e, &return_val);
-			if ((!return_val) && eti->cursor_mode != E_CURSOR_LINE && cursor_col != view_to_model_col(eti, eti->cols - 1))
+			if (atk_get_root () != NULL) {
+				if ((!return_val) && cursor_col != view_to_model_col(eti, eti->cols - 1))
+					eti_cursor_move_right (eti);
+			} else if ((!return_val) && eti->cursor_mode != E_CURSOR_LINE && cursor_col != view_to_model_col(eti, eti->cols - 1))
 				eti_cursor_move_right (eti);
 			return_val = 1;
 			break;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]